Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "setting up your environment" in CONTRIBUTING.md #913

Closed
maxrjones opened this issue Feb 16, 2021 · 3 comments · Fixed by #918
Closed

Update "setting up your environment" in CONTRIBUTING.md #913

maxrjones opened this issue Feb 16, 2021 · 3 comments · Fixed by #918
Labels
documentation Improvements or additions to documentation first-timers-only For absolute beginners good first issue Good for newcomers
Milestone
0.3.1

Comments

@maxrjones
Copy link
Member

maxrjones commented Feb 16, 2021 •
edited
Loading

Description of the problem

In the setting up your environment section of CONTRIBUTING.md, the instruction for activating the environment created from the environment.yml file is:

source activate ENVIRONMENT_NAME

Starting with conda 4.4, conda activate is recommended over source activate. Since the environment name (pygmt) is specified in environment.yml, ENVIRONMENT_NAME in this command could also be updated to pygmt with the new instruction being:

conda activate pygmt
@maxrjones maxrjones added the documentation Improvements or additions to documentation label Feb 16, 2021
@seisman seisman added the good first issue Good for newcomers label Feb 16, 2021
@seisman
Copy link
Member

seisman commented Feb 16, 2021

Sounds good.

Reference: https://docs.conda.io/projects/conda/en/latest/user-guide/getting-started.html#managing-python

@seisman seisman added this to the 0.3.1 milestone Feb 16, 2021
@weiji14 weiji14 added the first-timers-only For absolute beginners label Feb 17, 2021
@tawandamoyo
Copy link
Contributor

I'd like to work on this

@seisman
Copy link
Member

seisman commented Feb 17, 2021

I'd like to work on this

@tawandamoyo Great! You can following our contributing guidelines. Let us know if you need any help.

tawandamoyo added a commit to tawandamoyo/pygmt that referenced this issue Feb 17, 2021
@tawandamoyo
Update "setting up your environment" in CONTRIBUTING.md GenericMappin…
164ef20 
…gTools#913
@tawandamoyo tawandamoyo mentioned this issue Feb 17, 2021
Merged
5 tasks
maxrjones pushed a commit that referenced this issue Feb 17, 2021
@tawandamoyo
Update "setting up your environment" in CONTRIBUTING.md #913 (#918)
87cb403
sixy6e pushed a commit to sixy6e/pygmt that referenced this issue Dec 21, 2022
@tawandamoyo
Update "setting up your environment" in CONTRIBUTING.md GenericMappin…
e94561d 
…gTools#913 (GenericMappingTools#918)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation first-timers-only For absolute beginners good first issue Good for newcomers
Projects
None yet
Milestone
0.3.1
Development

Successfully merging a pull request may close this issue.

Update "setting up your environment" in CONTRIBUTING.md #913 tawandamoyo/pygmt
4 participants
@seisman @maxrjones @tawandamoyo @weiji14