Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use colorblind-friendly colors in the scatter plots gallery example #1013

Merged
merged 7 commits into from
Apr 12, 2021
Merged

Use colorblind-friendly colors in the scatter plots gallery example #1013

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
90585ad
Accessible colors for color blindness
vitorgt Mar 6, 2021
2b235ea
change colors, add different symbols
vitorgt Mar 7, 2021
c6d0936
Merge branch 'master' into patch-1
michaelgrund Mar 10, 2021
44d090b
Merge branch 'master' into patch-1
michaelgrund Mar 11, 2021
d1bafa1
remove style change; more opaque symbols
vitorgt Apr 6, 2021
85611b2
move plot/scatter.py to symbols/scatter.py
vitorgt Apr 10, 2021
e20c030
Merge branch 'master' into patch-1
vitorgt Apr 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions examples/gallery/plot/scatter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,19 @@
projection="X10c/10c",
frame=["xa0.2fg", "ya0.2fg", "WSrt"],
)
for color in ["blue", "orange", "green"]:
for color, style in [("gray73", "c"), ("darkorange", "s"), ("slateblue", "t")]:
x, y = np.random.rand(2, n) # random X and Y data in [0,1]
sizes = np.random.rand(n) * 0.5 # random size [0,0.5], in cm
# plot data points as circles (style="c"), with different sizes
fig.plot(
x=x,
y=y,
style="c",
style=style,
sizes=sizes,
color=color,
# Set the legend label,
# and set the circle size to be 0.25 cm (+S0.25c) in legend
label=f"{color}+S0.25c",
# and set the style size to be 0.25 cm (+S0.25{style}) in legend
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# and set the style size to be 0.25 cm (+S0.25{style}) in legend
# and set the style size to be 0.25 cm (+S0.25c) in legend

seisman marked this conversation as resolved.
Show resolved Hide resolved
label=f"{color}+S0.25{style}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the warning at https://pygmt-ln1ssu8ap-gmt.vercel.app/gallery/plot/scatter.html#sphx-glr-gallery-plot-scatter-py:

plot [WARNING]: Length <unit> s not supported - revert to default unit [cm]
plot [WARNING]: Length <unit> t not supported - revert to default unit [cm]

0.25c means 0.25 cm, so we shouldn't use style as the unit. If we'd like to change the size for each symbol in the legend, it'd better to also add it in the for loop. But I feel 0.25c is okay for those three symbols.

Suggested change
label=f"{color}+S0.25{style}",
label=f"{color}+S0.25c",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, and I'm sorry, I didn't know that, I thought it was the symbol to show, not the size in cm. Appreciated.

transparency=70, # set transparency level for all symbols
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
transparency=70, # set transparency level for all symbols
transparency=50, # set transparency level for all symbols

Perhaps 50 gives a better result.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please try 50, i.e. less transparency (more opaque). See also #1013 (comment).

)

Expand Down