Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny improvements for the text tutorial #1028

Merged
merged 7 commits into from
Mar 10, 2021

Conversation

core-man
Copy link
Member

@core-man core-man commented Mar 9, 2021

Description of proposed changes

Some tiny improvements for the tutorial for the text.

Related to #983 and #996.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the documentation Improvements or additions to documentation label Mar 9, 2021
@seisman seisman added this to the 0.3.1 milestone Mar 9, 2021
@seisman seisman marked this pull request as draft March 9, 2021 19:13
@seisman
Copy link
Member

seisman commented Mar 9, 2021

Some minor comments:

  1. Line 64: change "recognised" to "recognized" (American spelling)
  2. Line 65: change :gmt-docs:`cookbook/postscript-fonts.html` to
    :gmt-docs:`PostScript Fonts Used by GMT <cookbook/postscript-fonts.html>`

@core-man
Copy link
Member Author

Some minor comments:

  1. Line 64: change "recognised" to "recognized" (American spelling)
  2. Line 65: change :gmt-docs:`cookbook/postscript-fonts.html` to :gmt-docs:`PostScript Fonts Used by GMT <cookbook/postscript-fonts.html>`

done in a4121e4.

examples/tutorials/text.py Outdated Show resolved Hide resolved
@core-man core-man requested a review from seisman March 10, 2021 19:28
@seisman seisman added the skip-changelog Skip adding Pull Request to changelog label Mar 10, 2021
@seisman seisman marked this pull request as ready for review March 10, 2021 19:35
@seisman seisman merged commit 29d6088 into GenericMappingTools:master Mar 10, 2021
@core-man core-man deleted the tutorial-text branch March 10, 2021 19:40
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants