Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny improvements for the multi-parameter symbols example #1050

Merged
merged 7 commits into from
Mar 13, 2021

Conversation

core-man
Copy link
Member

Description of proposed changes

Tiny improvements for the comments in the gallery example for the multi-parameter symbols

Related to #983 and #996.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

Copy link
Member

@michaelgrund michaelgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there were only minor fixes, this PR looks good to me.

@michaelgrund michaelgrund added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Mar 13, 2021
@seisman
Copy link
Member

seisman commented Mar 13, 2021

@core-man It looks good. Could you also update the docstrings to make lines shorter than 80 chars?

@seisman seisman added this to the 0.3.1 milestone Mar 13, 2021
@core-man
Copy link
Member Author

@core-man It looks good. Could you also update the docstrings to make lines shorter than 80 chars?

done in fad6ba5.

@seisman seisman merged commit 231a953 into GenericMappingTools:master Mar 13, 2021
@core-man core-man deleted the multi-parameter-symbols branch March 13, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants