Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a gallery example showing individual basic geometric symbols #1211

Merged
merged 9 commits into from
Apr 16, 2021

Conversation

michaelgrund
Copy link
Member

@michaelgrund michaelgrund commented Apr 14, 2021

Description of proposed changes

As mentioned in #1193 so far we have no gallery example in which all basic symbols are shown. This PR adds such an example to the gallery.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

As mentioned in #1193 so far we have no gallery example in which all basic symbols are shown. This PR adds such an example to the gallery.
@michaelgrund michaelgrund added the documentation Improvements or additions to documentation label Apr 14, 2021
@michaelgrund michaelgrund added this to the 0.4.0 milestone Apr 14, 2021
@core-man
Copy link
Member

Great, the example will be very helpful. I have one question: shall we use a for loop instead of plot those symbols individually? This will make the code much shorter, e.g., the Line styles example.

Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
@michaelgrund
Copy link
Member Author

Great, the example will be very helpful. I have one question: shall we use a for loop instead of plot those symbols individually? This will make the code much shorter, e.g., the Line styles example.

Also thought about that, however, with all the 14 symbols I'm not sure if this would make the code more complex to read. What do the others think about it?

@seisman
Copy link
Member

seisman commented Apr 15, 2021

Great, the example will be very helpful. I have one question: shall we use a for loop instead of plot those symbols individually? This will make the code much shorter, e.g., the Line styles example.

I think the current script is good.

examples/gallery/symbols/basic_symbols.py Outdated Show resolved Hide resolved
examples/gallery/symbols/basic_symbols.py Outdated Show resolved Hide resolved
examples/gallery/symbols/basic_symbols.py Outdated Show resolved Hide resolved
examples/gallery/symbols/basic_symbols.py Outdated Show resolved Hide resolved
examples/gallery/symbols/basic_symbols.py Outdated Show resolved Hide resolved
examples/gallery/symbols/basic_symbols.py Outdated Show resolved Hide resolved
examples/gallery/symbols/basic_symbols.py Outdated Show resolved Hide resolved
examples/gallery/symbols/basic_symbols.py Outdated Show resolved Hide resolved
examples/gallery/symbols/basic_symbols.py Outdated Show resolved Hide resolved
examples/gallery/symbols/basic_symbols.py Outdated Show resolved Hide resolved
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few tiny suggestions. Otherwise, the PR looks good to me.

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@michaelgrund
Copy link
Member Author

Just a few tiny suggestions. Otherwise, the PR looks good to me.

Thanks for the review @seisman. Unfortunately, removed the units during the replcament actions.

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Apr 16, 2021
@seisman seisman requested review from core-man and maxrjones April 16, 2021 15:42
@core-man
Copy link
Member

This PR looks great to me. Only one minor comment above, but it's also okay for me to not use quotes.

@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 16, 2021
@seisman seisman changed the title Create gallery example showing individual basic geometric symbols Add a gallery example showing individual basic geometric symbols Apr 16, 2021
@seisman seisman merged commit 6fc9509 into master Apr 16, 2021
@seisman seisman deleted the gallery-basic-symbols branch April 16, 2021 19:10
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…ericMappingTools#1211)

Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Yao Jiayuan <coreman.seism@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants