Update fig.grd baseline images for GMT 6.2.0rc1 #1224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Updates broken tests on GMT 6.2.0rc1 for
fig.grdcontour
,fig.grdfilter
andpygmt.grd2cpt
.Note that the tests for
fig.grdfilter
are updates to the min/max values of the grid (and not baseline images). In GMT 6.1.1, the min/max values of agrdfilter
edxarray.DataArray
grid was slightly different to that of a NetCDF grid by a few decimal places (see #809), but this appears to be fixed so that the min/max values are exactly the same in GMT 6.2.0rc1 now. This resolves #859 I think, (originally fixed upstream at GenericMappingTools/gmt#5107).This PR should also:
fig.grdcontour
tests doesn't crash anymore with the upstream fix at The gmtlib_validate_id function stepped on another object's family gmt#5100.Addresses #1217
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version