Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fig.plot baseline images for GMT 6.2.0rc1 #1227

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Apr 22, 2021

Description of proposed changes

Address #1217

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added this to the 0.4.0 milestone Apr 22, 2021
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Apr 22, 2021
@github-actions
Copy link
Contributor

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_plot_colors.png
modified pygmt/tests/baseline/test_plot_colors_sizes.png
modified pygmt/tests/baseline/test_plot_colors_sizes_proj.png
modified pygmt/tests/baseline/test_plot_datetime.png
modified pygmt/tests/baseline/test_plot_from_file.png
modified pygmt/tests/baseline/test_plot_lines_with_arrows.png
modified pygmt/tests/baseline/test_plot_matrix.png
modified pygmt/tests/baseline/test_plot_matrix_color.png
modified pygmt/tests/baseline/test_plot_projection.png
modified pygmt/tests/baseline/test_plot_red_circles.png
modified pygmt/tests/baseline/test_plot_scalar_xy.png
modified pygmt/tests/baseline/test_plot_sizes.png
modified pygmt/tests/baseline/test_plot_sizes_colors_transparencies.png
modified pygmt/tests/baseline/test_plot_transparency.png
modified pygmt/tests/baseline/test_plot_varying_intensity.png
modified pygmt/tests/baseline/test_plot_varying_transparency.png
modified pygmt/tests/baseline/test_plot_vectors.png

Image diff(s)

Added images

Modified images

Path Old New
test_plot_colors.png
test_plot_colors_sizes.png
test_plot_colors_sizes_proj.png
test_plot_datetime.png
test_plot_from_file.png
test_plot_lines_with_arrows.png
test_plot_matrix.png
test_plot_matrix_color.png
test_plot_projection.png
test_plot_red_circles.png
test_plot_scalar_xy.png
test_plot_sizes.png
test_plot_sizes_colors_transparencies.png
test_plot_transparency.png
test_plot_varying_intensity.png
test_plot_varying_transparency.png
test_plot_vectors.png

Report last updated at commit fd9a594

@seisman seisman mentioned this pull request Apr 22, 2021
3 tasks
@maxrjones
Copy link
Member

The new images look good to me, but I would prefer to see the changed fig.plot() tests pass on each OS/version before approving. DVC pull currently fails on macOS-latest - Python 3.9 / NumPy 1.20.

@seisman
Copy link
Member Author

seisman commented Apr 22, 2021

The new images look good to me, but I would prefer to see the changed fig.plot() tests pass on each OS/version before approving. DVC pull currently fails on macOS-latest - Python 3.9 / NumPy 1.20.

Re-ran all CI tests. Please review it again.

Copy link
Member

@maxrjones maxrjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@seisman seisman merged commit 74a02ef into master Apr 22, 2021
@seisman seisman deleted the gmt-6.2.0rc1/plot branch April 22, 2021 16:40
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants