-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add categorical colorbars for plot, plot3d and line colors gallery examples #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in #1259 this PR fixes issues appearing during cpt creation and adds categorical colorbars to the examples.
michaelgrund
added
documentation
Improvements or additions to documentation
enhancement
Improving an existing feature
labels
May 10, 2021
michaelgrund
changed the title
WIP: Add categorical colorbars for plot and plot3d gallery examples
WIP: Add categorical colorbars for plot, plot3d and line colors gallery examples
May 10, 2021
michaelgrund
changed the title
WIP: Add categorical colorbars for plot, plot3d and line colors gallery examples
Add categorical colorbars for plot, plot3d and line colors gallery examples
May 11, 2021
weiji14
reviewed
May 11, 2021
seisman
reviewed
May 11, 2021
seisman
reviewed
May 11, 2021
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
approved these changes
May 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
seisman
added
final review call
This PR requires final review and approval from a second reviewer
and removed
enhancement
Improving an existing feature
labels
May 12, 2021
weiji14
approved these changes
May 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with this, just two small suggestions 😄
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
seisman
removed
the
final review call
This PR requires final review and approval from a second reviewer
label
May 13, 2021
6 tasks
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…amples (GenericMappingTools#1267) Co-authored-by: Dongdong Tian <seisman.info@gmail.com> Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
As discussed in #1259 this PR fixes issues appearing during cpt creation and adds categorical colorbars to the examples.
Previews:
Closes #1259.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version