Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fig.text baseline images for GMT 6.2.0rc2 #1292

Merged
merged 2 commits into from
May 25, 2021
Merged

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented May 25, 2021

Description of proposed changes

Fix broken tests on GMT 6.2.0rc2 for fig.text. This corrects the false positive passing tests due to #1242.

Addresses #1289.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

Fix broken tests on GMT 6.2.0rc2 for fig.text.
@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels May 25, 2021
@weiji14 weiji14 added this to the 0.4.0 milestone May 25, 2021
@weiji14 weiji14 self-assigned this May 25, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2021

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_text_angle_30.png
modified pygmt/tests/baseline/test_text_angle_font_justify_from_textfile.png
modified pygmt/tests/baseline/test_text_fill.png
modified pygmt/tests/baseline/test_text_font_bold.png
modified pygmt/tests/baseline/test_text_input_multiple_filenames.png
modified pygmt/tests/baseline/test_text_input_remote_filename.png
modified pygmt/tests/baseline/test_text_input_single_filename.png
modified pygmt/tests/baseline/test_text_justify_bottom_right_and_top_left.png
modified pygmt/tests/baseline/test_text_justify_parsed_from_textfile.png
modified pygmt/tests/baseline/test_text_multiple_lines_of_text.png
modified pygmt/tests/baseline/test_text_nonstr_text.png
modified pygmt/tests/baseline/test_text_pen.png
modified pygmt/tests/baseline/test_text_position.png
modified pygmt/tests/baseline/test_text_position_offset_with_line.png
modified pygmt/tests/baseline/test_text_round_clearance.png
modified pygmt/tests/baseline/test_text_single_line_of_text.png
modified pygmt/tests/baseline/test_text_transparency.png
modified pygmt/tests/baseline/test_text_varying_transparency.png

None

Image diff(s)

Added images

Modified images

Path Old New
test_text_angle_30.png
test_text_angle_font_justify_from_textfile.png
test_text_fill.png
test_text_font_bold.png
test_text_input_multiple_filenames.png
test_text_input_remote_filename.png
test_text_input_single_filename.png
test_text_justify_bottom_right_and_top_left.png
test_text_justify_parsed_from_textfile.png
test_text_multiple_lines_of_text.png
test_text_nonstr_text.png
test_text_pen.png
test_text_position.png
test_text_position_offset_with_line.png
test_text_round_clearance.png
test_text_single_line_of_text.png
test_text_transparency.png
test_text_varying_transparency.png

Report last updated at commit 96ff787

@weiji14 weiji14 marked this pull request as ready for review May 25, 2021 08:58
@weiji14 weiji14 requested a review from a team May 25, 2021 09:56
@seisman seisman merged commit 01e2feb into master May 25, 2021
@seisman seisman deleted the gmt-6.2.0rc2/text branch May 25, 2021 15:19
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants