Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xfail on grdtrack tests for GMT 6.2.0 #1304

Merged
merged 3 commits into from
Jun 6, 2021
Merged

Remove xfail on grdtrack tests for GMT 6.2.0 #1304

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f382f4
Remove xfail on grdtrack tests for GMT 6.2.0rc2
seisman May 27, 2021
cdbea46
Update the grdtrack tests so that it pass for the upcoming GMT 6.2.0
seisman Jun 3, 2021
23377f8
Merge branch 'master' into xfail/grdtrack
seisman Jun 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions pygmt/tests/test_grdtrack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ def fixture_dataarray():
)


@pytest.mark.xfail(reason="The reason why it fails is unclear now")
def test_grdtrack_input_dataframe_and_dataarray(dataarray):
"""
Run grdtrack by passing in a pandas.DataFrame and xarray.DataArray as
Expand All @@ -36,12 +35,11 @@ def test_grdtrack_input_dataframe_and_dataarray(dataarray):
output = grdtrack(points=dataframe, grid=dataarray, newcolname="bathymetry")
assert isinstance(output, pd.DataFrame)
assert output.columns.to_list() == ["longitude", "latitude", "bathymetry"]
npt.assert_allclose(output.iloc[0], [-110.9536, -42.2489, -2974.656296])
npt.assert_allclose(output.iloc[0], [-110.9536, -42.2489, -2790.488422])

return output


@pytest.mark.xfail(reason="The reason why it fails is unclear now")
def test_grdtrack_input_csvfile_and_dataarray(dataarray):
"""
Run grdtrack by passing in a csvfile and xarray.DataArray as inputs.
Expand All @@ -54,7 +52,7 @@ def test_grdtrack_input_csvfile_and_dataarray(dataarray):
assert os.path.exists(path=TEMP_TRACK) # check that outfile exists at path

track = pd.read_csv(TEMP_TRACK, sep="\t", header=None, comment=">")
npt.assert_allclose(track.iloc[0], [-110.9536, -42.2489, -2974.656296])
npt.assert_allclose(track.iloc[0], [-110.9536, -42.2489, -2790.488422])
finally:
os.remove(path=TEMP_TRACK)

Expand Down