Update colorbar, inset, legend and logo baseline images for GMT 6.2.0

[weiji14]

Description of proposed changes

Fix five broken tests on GMT 6.2.0 for fig.colorbar, fig.inset, fig.legend and fig.logo. Differences are mainly due to a different pen thickness setting. Also marking a test_plot3d_matrix_color as xfail on Windows due to incorrect -i parameter parsing.

Addresses #1320

Reminders

• Run make format and make check to make sure the code follows the style guide.
• Add tests for new features or tests that would have caught the bug that you're fixing.
• Add new public functions/methods/classes to doc/api/index.rst.
• Write detailed docstrings for all functions/methods.
• If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

• /format: automatically format and lint the code
• /test-gmt-dev: run full tests on the latest GMT development version

[github-actions]

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status	Path
modified	pygmt/tests/baseline/test_colorbar_box.png
modified	pygmt/tests/baseline/test_inset_aliases.png
modified	pygmt/tests/baseline/test_inset_context_manager.png
modified	pygmt/tests/baseline/test_legend_position.png
modified	pygmt/tests/baseline/test_logo_on_a_map.png

None

Image diff(s)

Added images

Modified images

Path	Old	New
test_colorbar_box.png
test_inset_aliases.png
test_inset_context_manager.png
test_legend_position.png
test_logo_on_a_map.png

Report last updated at commit 3270134

[weiji14]

test_plot3d_matrix_color still failing on Windows. See https://github.com/GenericMappingTools/pygmt/pull/1322/checks?check_run_id=2756778343#step:11:486:

__________________________ test_plot3d_matrix_color ___________________________
Error: Image dimensions did not match.
  Expected shape: (1040, 1729)
    D:\a\pygmt\pygmt\tmp-test-dir-with-unique-name\results\pygmt.tests.test_plot3d.test_plot3d_matrix_color\baseline.png
  Actual shape: (991, 1729)
    D:\a\pygmt\pygmt\tmp-test-dir-with-unique-name\results\pygmt.tests.test_plot3d.test_plot3d_matrix_color\result.png

baseline (correct)	result (wrong)

This test is using i=[0, 1, 2, 2], so perhaps something not handled properly with the bugfixes at GenericMappingTools/gmt#5289 or GenericMappingTools/gmt#5291?

pygmt/pygmt/tests/test_plot3d.py

Lines 375 to 392 in 638adab

	@pytest.mark.mpl_image_compare
	def test_plot3d_matrix_color(data, region):
	"""
	Plot the data passing in a matrix and using a colormap.
	"""
	fig = Figure()
	fig.plot3d(
	data=data,
	zscale=5,
	perspective=[225, 30],
	region=region,
	projection="X10c",
	style="c0.5c",
	cmap="rainbow",
	columns=[0, 1, 2, 2],
	frame=["a", "za"],
	)
	return fig

[seisman]

But it passes on Linux and macOS. I think we can mark it as xfail on Windows, and see if @joa-quim can help debug the Windows-only issue.

[weiji14]

I've marked test_plot3d_matrix_color as xfail on Windows (and reverted the dvc baseline image change to that test) at 3270134.

[joa-quim]

Sorry, what is it that you want me to test?

[seisman]

Sorry, what is it that you want me to test?

Here is a PyGMT script:

import numpy as np
import pygmt

datafile = "points.txt"

# array
data = np.loadtxt(datafile)
fig = pygmt.Figure()
fig.plot3d(
    data=data,
    zscale=5,
    perspective=[225, 30],
    region=[10, 70, -5, 10, 0, 1],
    projection="X10c",
    style="c0.5c",
    cmap="rainbow",
    frame=["a", "za"],
    i=[0, 1, 2, 2],
)
fig.savefig("plot3d-array.png")

The data file is points.txt.

The PyGMT test shows that the above script produces the correct (left side) image on Linux/macOS, but produces the wrong (right-side) image on Windows.

baseline (correct)	result (wrong)

It's related to recent changes about the -i option in GenericMappingTools/gmt#5289 and GenericMappingTools/gmt#5291. Please see if you can reproduce it.

[joa-quim]

Ok, but I want to first reproduce this example in Julia and I'm having some errors that I need to debug first.
Anyway I think that in Julia I never use the numeric values directly but parse them and construct a -i string

And I'll need some remembering on how to update my PyGMT. Remember that I use the code from repo directly and my GMT win build.