Add gallery example for grdgradient #1428

yohaimagen · 2021-08-10T10:11:22Z

adding a gallery example of producing a hillshade map out of a Data Elevation Model with pygmt.grdgradient

Preview at https://pygmt-git-fork-yohaimagen-grdgradientgalleryexample-gmt.vercel.app/gallery/images/grdgradient.html

Fixes #1425

Co-authored-by: Yao Jiayuan <coreman.seism@gmail.com>

yohaimagen · 2021-08-10T11:16:34Z

At #1425 I suggest also extending the Plotting Earth relief tutorial to include a section that uses shading=True in grdimage which use grdgradient in order of making a hillshade map, and from there reference to this gallery example for more specific usage of grdgradient, do you think it necessary? and if yes should I do it over here or on a different pull request?

examples/gallery/images/grdgradient.py

michaelgrund · 2021-08-30T06:43:03Z

examples/gallery/images/grdgradient.py

+# Load sample grid (3 arc second global relief) in target area
+grid = pygmt.datasets.load_earth_relief(resolution="03s", region=region)
+
+# calculate the reflection of a light source projecting from west to east(azimuth 270)


Suggested change

# calculate the reflection of a light source projecting from west to east(azimuth 270)

# calculate the reflection of a light source projecting from west to east (azimuth 270 degrees)

examples/gallery/images/grdgradient.py

seisman · 2021-09-03T05:10:14Z

examples/gallery/images/grdgradient.py

+# --------------- plotting the hillshade map -----------
+pygmt.makecpt(cmap="gray", series=[-1.5, 0.3, 0.01])
+fig.grdimage(
+    grid=dgrid,


Can anyone confirm the definition of a hillshaded map? Based on my own understanding, hillshading means plotting the elevation data grid, and also apply the (-1,1) intensity grid dgrid for each point. Thus a hillshaded map should be like this (the CPT range should also be changed to reflect the elevation range):

Suggested change

grid=dgrid,

grid=grid,

shading=dgrid,

There is no one answer to this. I think what is plotted in this gallery example could be considered a 'hillshade map' (showing only the hillshade component) but not a 'hillshaded map' implying that the hillshade component alters the appearance of other data (e.g., elevation) that are shown on the map.

My opinion is that it would be better to plot a slope map for the simple grdgradient gallery example and that hillshading should be covered in a different tutorial that can go into different strategies (e.g., multi-directional, mixing slope and hillshade for illumination, transparent overlays versus grdgradient's shading parameter, etc). Sorry for not commenting about this earlier. It will be a great addition to have an example for grdgradient.

There is no one answer to this. I think what is plotted in this gallery example could be considered a 'hillshade map' (showing only the hillshade component) but not a 'hillshaded map' implying that the hillshade component alters the appearance of other data (e.g., elevation) that are shown on the map.

Agree with @meghanrjones regarding this point! I think the example itself is good as is in the current form but would also suggest to add another example/tutorial on this topic.

Ill agree that a slops map is more intuitive when you think on the gradient of a DEM. On the other hand, at least in my experience, shade maps are more intuitive to use(you are seeing the topography directly).

Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>

.github/workflows/cache_data.yaml

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

examples/gallery/images/grdgradient.py

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

seisman

@yohaimagen Nice work. The example now looks good to me.

yohaimagen · 2021-09-16T06:38:36Z

Thanks!
We still have one problem when looking in the deployment the title of the example is getting outside of the respective white box.

Can we decrease the font size in that case? or we should change the title?

seisman · 2021-09-16T06:42:27Z

Maybe we can change the title to "Calculating grid gradient and radiance".

…imagen/pygmt into grdgradient_gallery_example

examples/gallery/images/grdgradient.py

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

examples/gallery/images/grdgradient.py

michaelgrund

Except the minor changes I suggested this PR looks good to me.

examples/gallery/images/grdgradient.py

Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com> Co-authored-by: Will Schlitzer <schlitzer90@gmail.com> Co-authored-by: Meghan Jones <meghanj@alum.mit.edu> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

yohaimagen and others added 6 commits August 6, 2021 15:30

add myself 'Yohai Magen' to authers

e4dbdaa

Merge branch 'GenericMappingTools:main' into add_myself_to_AUTHORS.md

9ac4a6c

Update AUTHORS.md

a546150

Co-authored-by: Yao Jiayuan <coreman.seism@gmail.com>

adding a gallery example to gedgradient

c5ecf3a

changing figure size

f5f495c

reformat

519ad80

yohaimagen self-assigned this Aug 10, 2021

yohaimagen added the documentation Improvements or additions to documentation label Aug 10, 2021

seisman added this to the 0.5.0 milestone Aug 10, 2021

corecting typos

51a1397

vercel bot temporarily deployed to Preview August 30, 2021 04:24 Inactive

weiji14 requested a review from a team August 30, 2021 04:28

Merge branch 'main' into grdgradient_gallery_example

7922d5a

michaelgrund reviewed Aug 30, 2021

View reviewed changes

examples/gallery/images/grdgradient.py Outdated Show resolved Hide resolved

michaelgrund reviewed Aug 30, 2021

View reviewed changes

examples/gallery/images/grdgradient.py Outdated Show resolved Hide resolved

seisman reviewed Sep 3, 2021

View reviewed changes

Update examples/gallery/images/grdgradient.py

fb5a71b

Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>

vercel bot temporarily deployed to Preview September 4, 2021 05:34 Inactive

yohaimagen and others added 6 commits September 4, 2021 08:34

Update examples/gallery/images/grdgradient.py

e5338be

Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>

Update examples/gallery/images/grdgradient.py

2db53ea

Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>

Update examples/gallery/images/grdgradient.py

490fe5d

Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>

Update examples/gallery/images/grdgradient.py

bc75bff

Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>

Update examples/gallery/images/grdgradient.py

485093f

Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>

Merge branch 'main' into grdgradient_gallery_example

77814bf

vercel bot temporarily deployed to Preview September 4, 2021 05:44 Inactive

swaping places of original and grdient data

75ad23c

vercel bot temporarily deployed to Preview September 4, 2021 14:18 Inactive

add changes to exampeels instad of gallery

8824389

seisman reviewed Sep 15, 2021

View reviewed changes

.github/workflows/cache_data.yaml Outdated Show resolved Hide resolved

Update .github/workflows/cache_data.yaml

e06dcd9

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

vercel bot temporarily deployed to Preview September 15, 2021 11:40 Inactive

recommenting pull_request

e98808a

vercel bot temporarily deployed to Preview September 15, 2021 12:25 Inactive

Merge branch 'main' into grdgradient_gallery_example

391b1dd

vercel bot temporarily deployed to Preview September 15, 2021 13:45 Inactive

seisman reviewed Sep 16, 2021

View reviewed changes

Apply suggestions from code review

0c6e53d

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

vercel bot temporarily deployed to Preview September 16, 2021 06:16 Inactive

seisman added the final review call This PR requires final review and approval from a second reviewer label Sep 16, 2021

seisman approved these changes Sep 16, 2021

View reviewed changes

yohaimagen added 2 commits September 16, 2021 10:43

change title

b061927

Merge branch 'grdgradient_gallery_example' of https://github.com/yoha…

2b9bddb

…imagen/pygmt into grdgradient_gallery_example

vercel bot temporarily deployed to Preview September 16, 2021 07:45 Inactive

Merge branch 'main' into grdgradient_gallery_example

5fecb09

seisman reviewed Sep 16, 2021

View reviewed changes

examples/gallery/images/grdgradient.py Outdated Show resolved Hide resolved

examples/gallery/images/grdgradient.py Outdated Show resolved Hide resolved

yohaimagen and others added 2 commits September 16, 2021 10:49

Update examples/gallery/images/grdgradient.py

b931683

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

add sugestion manually

a27c700

vercel bot temporarily deployed to Preview September 16, 2021 07:54 Inactive

seisman reviewed Sep 16, 2021

View reviewed changes

examples/gallery/images/grdgradient.py Outdated Show resolved Hide resolved

michaelgrund approved these changes Sep 16, 2021

View reviewed changes

examples/gallery/images/grdgradient.py Outdated Show resolved Hide resolved

Apply suggestions from code review

90a7dff

Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

vercel bot temporarily deployed to Preview September 17, 2021 05:08 Inactive

seisman merged commit 0327262 into GenericMappingTools:main Sep 17, 2021

seisman removed the final review call This PR requires final review and approval from a second reviewer label Sep 17, 2021

yohaimagen deleted the grdgradient_gallery_example branch September 17, 2021 05:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add gallery example for grdgradient #1428

Add gallery example for grdgradient #1428

yohaimagen commented Aug 10, 2021 •

edited by weiji14

Loading

yohaimagen commented Aug 10, 2021

michaelgrund Aug 30, 2021

seisman Sep 3, 2021

maxrjones Sep 3, 2021

michaelgrund Sep 4, 2021

yohaimagen Sep 4, 2021

seisman left a comment

yohaimagen commented Sep 16, 2021

seisman commented Sep 16, 2021

michaelgrund left a comment

	# calculate the reflection of a light source projecting from west to east(azimuth 270)
	# calculate the reflection of a light source projecting from west to east (azimuth 270 degrees)

Add gallery example for grdgradient #1428

Add gallery example for grdgradient #1428

Conversation

yohaimagen commented Aug 10, 2021 • edited by weiji14 Loading

yohaimagen commented Aug 10, 2021

michaelgrund Aug 30, 2021

Choose a reason for hiding this comment

seisman Sep 3, 2021

Choose a reason for hiding this comment

maxrjones Sep 3, 2021

Choose a reason for hiding this comment

michaelgrund Sep 4, 2021

Choose a reason for hiding this comment

yohaimagen Sep 4, 2021

Choose a reason for hiding this comment

seisman left a comment

Choose a reason for hiding this comment

yohaimagen commented Sep 16, 2021

seisman commented Sep 16, 2021

michaelgrund left a comment

Choose a reason for hiding this comment

yohaimagen commented Aug 10, 2021 •

edited by weiji14

Loading