Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin dvc version from 2.3.0 #1559

Merged
merged 3 commits into from
Oct 15, 2021
Merged

Unpin dvc version from 2.3.0 #1559

merged 3 commits into from
Oct 15, 2021

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 2, 2021

Description of proposed changes

This reverts commit 09847a7 in #1544.

Closes #1543.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Oct 3, 2021
@weiji14
Copy link
Member

weiji14 commented Oct 15, 2021

Using dvc-2.8.1 seems to work 🎉

Vercel CI failure is unrelated (see #1575 (comment)), so can probably merge after the other tests pass.

@weiji14 weiji14 marked this pull request as ready for review October 15, 2021 03:03
@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Oct 15, 2021
@weiji14 weiji14 changed the title WIP: Unpin dvc version Unpin dvc version from 2.3.0 Oct 15, 2021
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Oct 15, 2021
@seisman seisman added this to the 0.5.0 milestone Oct 15, 2021
@seisman seisman merged commit 2bad7f3 into main Oct 15, 2021
@seisman seisman deleted the unpin-dvc branch October 15, 2021 13:33
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
This reverts commit 09847a7.

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI jobs fail to pull data from the dagshub repository
2 participants