Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor x2sys_cross to remove verbose info and return output statements #1572

Merged
merged 3 commits into from
Oct 23, 2021

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Oct 5, 2021

Description of proposed changes

Silences captured stderr messages in the log from running x2sys_cross. Patches #546.

___________________ test_x2sys_cross_input_file_output_file ____________________
----------------------------- Captured stderr call -----------------------------
x2sys_cross [INFORMATION]: Files found: 1
x2sys_cross [INFORMATION]: Checking for duplicates :
x2sys_cross [INFORMATION]: 0 found
Warning: ss [WARNING]: No time column, use dummy times
Not a valid unit: c [meter assumed]
Not a valid unit: c [meter assumed]
x2sys_cross [INFORMATION]: Writing Data Table to file /home/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/X2SYSr58ly6wo/tmp_coe.txt
x2sys_cross [INFORMATION]: Processing @tut_ship - @tut_ship : 14294
_________________ test_x2sys_cross_input_file_output_dataframe _________________
----------------------------- Captured stderr call -----------------------------
x2sys_cross [INFORMATION]: Files found: 1
x2sys_cross [INFORMATION]: Checking for duplicates :
x2sys_cross [INFORMATION]: 0 found
Warning: ss [WARNING]: No time column, use dummy times
Not a valid unit: c [meter assumed]
Not a valid unit: c [meter assumed]
x2sys_cross [INFORMATION]: Writing Data Table to file /tmp/pygmt-hmkwjhzz.txt
x2sys_cross [INFORMATION]: Processing @tut_ship - @tut_ship : 14294
______________ test_x2sys_cross_input_dataframe_output_dataframe _______________
----------------------------- Captured stderr call -----------------------------
x2sys_cross [INFORMATION]: Files found: 1
x2sys_cross [INFORMATION]: Checking for duplicates :
x2sys_cross [INFORMATION]: 0 found
Warning: ss [WARNING]: No time column, use dummy times
Not a valid unit: c [meter assumed]
Not a valid unit: c [meter assumed]
x2sys_cross [INFORMATION]: Writing Data Table to file /tmp/pygmt-1o71k5fm.txt
x2sys_cross [INFORMATION]: Processing track-c48ce7c - track-c48ce7c : 14
____________________ test_x2sys_cross_input_two_dataframes _____________________
----------------------------- Captured stderr call -----------------------------
x2sys_cross [INFORMATION]: Files found: 2
x2sys_cross [INFORMATION]: Checking for duplicates :
x2sys_cross [INFORMATION]: 0 found
x2sys_cross [INFORMATION]: Writing Data Table to file /tmp/pygmt-twq1zmqn.txt
x2sys_cross [INFORMATION]: Processing track-ab8038e - track-ce196c4 : 30
__________________ test_x2sys_cross_input_dataframe_with_nan ___________________
----------------------------- Captured stderr call -----------------------------
Warning: ss [WARNING]: No time column, use dummy times
_____________________ test_x2sys_cross_input_two_filenames _____________________
----------------------------- Captured stderr call -----------------------------
x2sys_cross [INFORMATION]: Files found: 2
x2sys_cross [INFORMATION]: Checking for duplicates :
x2sys_cross [INFORMATION]: 0 found
Warning: ss [WARNING]: No time column, use dummy times
Not a valid unit: c [meter assumed]
Not a valid unit: c [meter assumed]
x2sys_cross [INFORMATION]: Writing Data Table to file /tmp/pygmt-qlquqjz8.txt
x2sys_cross [INFORMATION]: Processing track_0 - track_1 : 24
_______________ test_x2sys_cross_region_interpolation_numpoints ________________
----------------------------- Captured stderr call -----------------------------
Warning: ss [WARNING]: No time column, use dummy times
Not a valid unit: c [meter assumed]
Not a valid unit: c [meter assumed]
_________________________ test_x2sys_cross_trackvalues _________________________
----------------------------- Captured stderr call -----------------------------
Warning: ss [WARNING]: No time column, use dummy times
Not a valid unit: c [meter assumed]
Not a valid unit: c [meter assumed]

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Oct 5, 2021
@weiji14 weiji14 marked this pull request as ready for review October 12, 2021 02:58
@weiji14 weiji14 self-assigned this Oct 20, 2021
@weiji14 weiji14 merged commit 9cbd8f9 into main Oct 23, 2021
@weiji14 weiji14 deleted the refactor-tests/x2sys_cross branch October 23, 2021 19:37
@seisman seisman added this to the 0.5.0 milestone Oct 25, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…nts (GenericMappingTools#1572)

Silences captured stderr messages in the log from running x2sys_cross.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants