-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gallery example to showcase blockmean #1598
Conversation
Btw, are there any specific reasons why no alias for the |
Not yet implemented I guess. Maybe open a separate PR to add it. P.S. You should add a P.P.S. The macOS docs build is failing due to an unrelated reason. Will open a separate issue or maintenance PR to resolve it. |
Sorry for accidentally marking this "Ready for review." Already converted back to draft. |
Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few additional comments! Sorry that I didn't catch it on the first pass @michaelgrund
Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
/format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just the one suggestion
Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Will Schlitzer <schlitzer90@gmail.com> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Description of proposed changes
Partly addressing #1352 here's a gallery example in which two different usages of
blockmean
are shown using the build-in japan_quake dataset.Preview at https://pygmt-git-gallery-blockmean-eq-gmt.vercel.app/gallery/histograms/blockm.html
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version