Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xfail from passing grdimage tests #1656

Merged
merged 9 commits into from
Jan 5, 2022
Merged

Remove xfail from passing grdimage tests #1656

merged 9 commits into from
Jan 5, 2022

Conversation

maxrjones
Copy link
Member

Description of proposed changes

This PR removes the xfail mark from test_grdimage_grid_and_shading_with_xarray and splits off the passing tests from test_grdimage_central_meridians_and_standard_parallels, which marks all tests using -JQ as xfail. A suggestion for a more clever way to do this with pytest parameterize would be welcome.

Part of #1644
Closes #618

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@maxrjones maxrjones mentioned this pull request Dec 13, 2021
31 tasks
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Dec 17, 2021
@seisman seisman added this to the 0.6.0 milestone Dec 17, 2021
Co-authored-by: Dongdong Tian <seisman@users.noreply.github.com>
@maxrjones maxrjones marked this pull request as draft December 22, 2021 03:11
pygmt/tests/test_grdimage.py Outdated Show resolved Hide resolved
pygmt/tests/test_grdimage.py Outdated Show resolved Hide resolved
pygmt/tests/test_grdimage.py Outdated Show resolved Hide resolved
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@maxrjones maxrjones marked this pull request as ready for review January 3, 2022 17:35
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Jan 4, 2022
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jan 5, 2022
@seisman seisman merged commit b0f9be7 into main Jan 5, 2022
@seisman seisman deleted the update-xfail branch January 5, 2022 04:36
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Co-authored-by: Dongdong Tian <seisman@users.noreply.github.com>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the use of a separate file for shading (grdimage -I)
3 participants