Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change test_grdproject.py to use static_earth_relief #1683

Merged
merged 9 commits into from
Feb 15, 2022

Conversation

willschlitzer
Copy link
Contributor

Description of proposed changes

This PR refactors the pygmt.grdproject tests to use xarray.testing.assert_allclose() rather than pygmt.grdinfo() in preparation for the deprecation associated with better return values for grdinfo (#593).

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Dec 21, 2021
@willschlitzer willschlitzer added this to the 0.6.0 milestone Dec 21, 2021
@willschlitzer willschlitzer self-assigned this Dec 21, 2021
@willschlitzer
Copy link
Contributor Author

I wasn't able to change the dimensions of the output grid using the region parameter. I don't want to use grdcut in this test to get a smaller input grid, but I'm not sure why I'm unable to change the 14x8 output. I tried inputting region coordinates both in lat/long and x/y.

@maxrjones
Copy link
Member

I wasn't able to change the dimensions of the output grid using the region parameter. I don't want to use grdcut in this test to get a smaller input grid, but I'm not sure why I'm unable to change the 14x8 output. I tried inputting region coordinates both in lat/long and x/y.

The behavior of region is a bit trickier in grdproject than the other modules. Using region alone will impact what data are projected but won't impact the number of nodes unless spacing or dpi are set. Without one of those two other parameters, the default is to output a grid with the same number of nodes as the input grid such that the x_inc and/or y_inc would be smaller if a subregion is selected.

Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Feb 15, 2022
@seisman seisman changed the title Use xarray.testing rather than pygmt.grdinfo in grdproject tests Change test_grdproject.py to use static_earth_relief Feb 15, 2022
@maxrjones maxrjones merged commit ab029b8 into main Feb 15, 2022
@maxrjones maxrjones deleted the remove-grdinfo/grdproject branch February 15, 2022 20:09
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Feb 16, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…ools#1683)

Use xarray.testing and static_earth_relief in grdproject tests.

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants