-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a single function for loading any sample dataset #1685
Merged
Merged
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
479c336
Use a single function for loading any sample dataset
maxrjones 28e0597
Use separate functions for reading tables
maxrjones c34cfa8
Merge branch 'main' into load-sample-datasets
maxrjones 2f6e3ad
Apply suggestions from code review
maxrjones 4df5b37
Suppress warning with kwargs rather than new functions
maxrjones 0a7fcdd
Merge branch 'main' into load-sample-datasets
maxrjones 7dc6a31
Use only one function for all sample datasets
maxrjones 9f2a32f
Update warnings
maxrjones 6e38361
Deprecate other sample dataset functions
maxrjones a909a29
Apply suggestions from code review
maxrjones e83feb5
Use dict mapping in load_sample_data
maxrjones 1209764
Merge branch 'main' into load-sample-datasets
maxrjones 31807e7
Alphabetize keys
maxrjones 12dfc9a
Apply suggestions from code review
maxrjones c11ddeb
Merge branch 'main' into load-sample-datasets
maxrjones File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking if we can merge the
list_sample_data()
function intoload_sample_data()
, so that we don't have to maintain two dictionaries.For example, calling
load_sample_data()
without giving a name can return the name-description dict.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to keep them separate even though it requires two dictionaries because I think overall it's simpler to have each function have one purpose.