Pull dvc baseline images from gmt-6.4 branch to test GMT dev #1865
Conversation
Make it easier to catch any changes in upstream GMT that break PyGMT.
.github/workflows/ci_tests_dev.yaml
Outdated
| ORIGINAL_BRANCH=$(git branch --show-current) | ||
| # Pull down GMT 6.4 baseline images from | ||
| # https://github.com/GenericMappingTools/pygmt/pull/1791 | ||
| git checkout update-baseline-images-for-gmt-dev | ||
| dvc pull | ||
| ls -lhR pygmt/tests/baseline/ | ||
| git checkout ${ORIGINAL_BRANCH} |
There was a problem hiding this comment.
I'm wondering if we should have a gmt-6.4 or a more general gmt-dev branch.
So changes in #1791 can be merged into the gmt-dev branch and the ci_tests_dev workflow can test the gmt-dev branch instead.
Of course, we need to keep the gmt-dev branch up-to-date with the main branch, either manually or via workflow.
There was a problem hiding this comment.
I'm wondering if we should have a
gmt-6.4or a more generalgmt-devbranch.
A gmt-6.4 branch sounds good, best not to have a very long-running branch like gmt-dev to avoid scrolling down so much in a PR.
So changes in #1791 can be merged into the
gmt-devbranch and theci_tests_devworkflow can test thegmt-devbranch instead.Of course, we need to keep the
gmt-devbranch up-to-date with themainbranch, either manually or via workflow.
Let's start with manual for now, and if things break very often, we can have a scheduled cron job to update the gmt-6.4 branch every week or so.
There was a problem hiding this comment.
I've created the gmt-6.4 branch (https://github.com/GenericMappingTools/pygmt/tree/gmt-6.4).
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
added
the
final review call
seisman
changed the title
seisman
removed
the
final review call
…MappingTools#1865) Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Description of proposed changes
Make it easier to catch any changes in upstream GMT that break PyGMT, until PyGMT bumps its minimum required version to GMT 6.4.
This modifies the GMT Dev Tests workflow to
dvc pullimages from @seisman's branch at #1791 that has the newer baseline images generated using GMT 6.4, so that the daily scheduled GMT Dev tests can pass.Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version