-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use longname placeholders in the docstrings for common options #1932
Merged
Merged
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
6580b8c
Use longname placeholders in the docstrings
seisman fa92fa3
Replace {J} with {projection}
seisman d2a4f85
Replace {V} with {verbose}
seisman 3433876
Replace {U} with {timestamp}
seisman c26bea0
Replace {R} with {region}
seisman d40ee56
Replace {B} with {frame}
seisman 4af5955
Replace {a} with {aspatial}
seisman d097e09
Replace {b} with {binary}
seisman 2a3b60c
Replace {d} with {nodata}
seisman e1b6b9d
Replace {c} with {panel}
seisman 7c7ce4a
Replace {e} with {find}
seisman eb42d8e
Replace {f} with {coltypes}
seisman 4f6de92
Replace {g} with {gap}
seisman 4c68f79
Replace {h} with {header}
seisman bba4149
Replace {i} with {incols}
seisman f916de1
Replace {j} with {distcalc}
seisman cfe9221
Replace {l} with {label}
seisman f1419a8
Replace {n} with {interpolation}
seisman 66a35c9
Replace {o} with {outcols}
seisman dbff502
Replace {p} with {perspective}
seisman de754c2
Replace {r} with {registration}
seisman cbef92e
Replace {s} with {skiprows}
seisman d0ef6aa
Replace {t} with {transparency}
seisman 65f6f90
Replace {w} with {wrap}
seisman 8cfa283
Replace {x} with {cores}
seisman e39d0c3
Replace {XY} with {xyshift}
seisman 6de914e
Replace {CPT} with {cmap}
seisman dc55b4a
Replace {A} with {area_thresh}
seisman cb1fa23
Replace {G} with {color}
seisman e0cc783
Replace {W} with {pen}
seisman 5fdb82f
Revert incorrect replacements during the batch replacements
seisman 4a8b60c
Merge branch 'main' into longname-docstrings
seisman ef59237
Merge branch 'main' into longname-docstrings
seisman 9dccaa4
Remove unmaintained list of placeholders in the fmt_docstring function
seisman 6f9818f
Merge branch 'main' into longname-docstrings
seisman 8e175dc
Merge branch 'main' into longname-docstrings
seisman ec5d76c
Use longname docstrings in binstats
seisman eecece5
Merge branch 'main' into longname-docstrings
seisman 3e3b33f
Merge branch 'main' into longname-docstrings
seisman 32023f7
Merge branch 'main' into longname-docstrings
seisman 60c159f
Merge branch 'main' into longname-docstrings
seisman b4a7fa8
Merge branch 'main' into longname-docstrings
seisman f9d3155
Merge branch 'main' into longname-docstrings
seisman d8fabc4
Merge branch 'main' into longname-docstrings
seisman 328414e
Merge branch 'main' into longname-docstrings
seisman e51785b
Update ternary.py
seisman 8c8c36f
Fix
seisman 819120e
Merge branch 'main' into longname-docstrings
seisman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the long names, but then there's a small problem with sorting the parameters. Previously we sorted by asciibetical order (e.g. ABCabc), and it somewhat made sense since the small-letter GMT parameters like
c
/f
/p
/t
were rarely used. Now that we switch to the long-form, do we still go with the original GMT sorting, or change to sorting by a long-parameter's first character?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a good answer for this, but packages like numpy and pandas don't sort their parameters alphabetically. I think we also don't have to do that.