Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure.histogram and pygmt.info: Remove parameter 'table', use 'data' instead #1975

Merged
merged 3 commits into from
Jun 24, 2022
Merged

Figure.histogram and pygmt.info: Remove parameter 'table', use 'data' instead #1975

merged 3 commits into from
Jun 24, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Jun 23, 2022

Description of proposed changes

Related to #1966.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs deprecation Deprecating a feature and removed maintenance Boring but important stuff for the core devs labels Jun 23, 2022
@seisman seisman added this to the 0.7.0 milestone Jun 23, 2022
@weiji14 weiji14 changed the title histogram/info: Remove parameter 'table', use 'data' instead Figure.histogram/info: Remove parameter 'table', use 'data' instead Jun 23, 2022
@weiji14 weiji14 changed the title Figure.histogram/info: Remove parameter 'table', use 'data' instead Figure.histogram and pygmt.info: Remove parameter 'table', use 'data' instead Jun 23, 2022
@seisman seisman merged commit e8ea414 into main Jun 24, 2022
@seisman seisman deleted the deprecate-table branch June 24, 2022 00:20
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seisman
Figure.histogram and pygmt.info: Remove parameter 'table', use 'data'…
349a7ed 
… instead (GenericMappingTools#1975)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

@michaelgrund michaelgrund michaelgrund approved these changes

Assignees
No one assigned
Labels
deprecation Deprecating a feature
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@seisman @michaelgrund @weiji14