Refactor the gmt.clib package #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate the functions for finding libgmt.
|
I'm still not entirely happy with the virtual file mechanics. It would make a lot more sense for the virtual file to be its own class but that doesn't match with the way GMT does things. For one, it would need the current |
|
@seisman I made some changes to the |
weiji14
added a commit
that referenced
this pull request
Jun 22, 2020
Should be GMT_IS_OUTPUT instead of GMT_OUTPUT. Also update some docstrings that were missed in the #210 refactor PR.
weiji14
added a commit
that referenced
this pull request
Jul 14, 2020
Should be GMT_IS_OUTPUT instead of GMT_OUTPUT. Also update some docstrings that were missed in the #210 refactor PR.
weiji14
added a commit
that referenced
this pull request
Jul 16, 2020
* Add registration (r) to common options * Set valid GMT data mode as GMT_IS_OUTPUT Should be GMT_IS_OUTPUT instead of GMT_OUTPUT. Also update some docstrings that were missed in the #210 refactor PR. * Simplify grid region extent calculation * Refactor virtualfile_from_grid and dataarray_to_matrix to use accessor * Fix tests where virtual grid had wrong region, registration and gtype * Expect failures from two grdview tests that used wrong coordinate system * Fix test_grdimage_over_dateline by using gridline instead of pixel reg * Flip grid array left right in xarray instead of in numpy * Test with a grid that does not reach the North Pole Values go from latitude 89S to 89N. Avoids the `grdimage [INFORMATION]: 359 (of 361) inconsistent grid values at North pole.` message. * Try just running test_grdimage_over_dateline first before other tests * Say why we need to run test_grdimage_over_dateline before other tests * Register the custom runfirst pytest marker
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A much needed refactor of the
gmt.clibpackage.LibGMTtoSessionbecause that is what it actually is (the GMT API session).clib.coretoclib.sessionand break upclib.utilsintoclib.loading(functions for loading libgmt) andclib.conversion(functions that handle the ctypes conversions from numpy, etc).*_to_vfiletovirtualfile_from_*createanddestroymethods now set the session pointer (Session.session_pointer), which simplifies the__enter__and__exit__methods.Session.get_constantis now implemented asSession.__getitem__so getting a constant is now much shorter:self["GMT_IS_MATRIX"].