Skip to content

Conversation

@weiji14
Copy link
Member

@weiji14 weiji14 commented Dec 30, 2022

Description of proposed changes

Previous expression was matching too strictly on the crontab, so using endsWith instead. xref https://docs.github.com/en/actions/learn-github-actions/expressions#endswith. Inspired by https://github.com/orgs/community/discussions/25662#discussioncomment-3248648.

Cherry-picked from 0bf561f and 21cfbff in #2283

Patches #1833. Fixes #2286.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

Previous expression was matching too strictly on the crontab, so using endsWith instead. xref https://docs.github.com/en/actions/learn-github-actions/expressions#endswith. Patches #1833.
@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Dec 30, 2022
@weiji14 weiji14 added this to the 0.9.0 milestone Dec 30, 2022
@weiji14 weiji14 self-assigned this Dec 30, 2022
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't verify if it works but at least it looks good.

@weiji14 weiji14 marked this pull request as ready for review December 31, 2022 03:00
@weiji14
Copy link
Member Author

weiji14 commented Dec 31, 2022

Can't verify if it works but at least it looks good.

Well, we'll find out next Wednesday 🤞

@weiji14 weiji14 enabled auto-merge (squash) December 31, 2022 03:01
@seisman seisman disabled auto-merge December 31, 2022 04:16
@seisman seisman merged commit ee04f5a into main Dec 31, 2022
@seisman seisman deleted the wednesday-fulltests branch December 31, 2022 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run full tests (including inline doctests) in workflows

3 participants