Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --sdist --wheel flags from the build command #2420

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Remove --sdist --wheel flags from the build command #2420

merged 2 commits into from
Mar 15, 2023

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 14, 2023

Description of proposed changes

Simply use python -m build without any flags following the official recommendations (https://pypa-build.readthedocs.io/en/stable/index.html).

Please note that both python -m build and python -m build --sdist --wheel can build source and binary distributions but the details are different:

By default, a source distribution (sdist) is built from {srcdir} and a binary distribution (wheel) is built from the sdist. This is recommended as it will ensure the sdist can be used to build wheels. Pass -s/–sdist and/or -w/–wheel to build a specific distribution. If you do this, the default behavior will be disabled, and all artifacts will be built from {srcdir} (even if you combine -w/–wheel with -s/–sdist, the wheel will be built from {srcdir}).

@seisman seisman added the maintenance Boring but important stuff for the core devs label Mar 14, 2023
@seisman seisman added this to the 0.9.0 milestone Mar 14, 2023
@seisman seisman added the needs review This PR has higher priority and needs review. label Mar 14, 2023
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Mar 14, 2023
@maxrjones maxrjones mentioned this pull request Mar 14, 2023
36 tasks
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a minor difference, but best to check on TestPyPI after merging this PR to see what the sdist and bdist has changed. Hopefully the file size gets smaller 🙂

@seisman seisman merged commit 524ccbf into main Mar 15, 2023
@seisman seisman deleted the fix-build branch March 15, 2023 02:58
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 15, 2023
@seisman
Copy link
Member Author

seisman commented Mar 15, 2023

Seems like a minor difference, but best to check on TestPyPI after merging this PR to see what the sdist and bdist has changed. Hopefully the file size gets smaller 🙂

No changes on file sizes 🙂 (Compare https://test.pypi.org/project/pygmt/0.8.1.dev98/#files and https://test.pypi.org/project/pygmt/0.8.1.dev99/#files).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants