Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'python -m pip install' instead of 'pip install' #2490

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Apr 9, 2023

Description of proposed changes

Closes #2419.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Apr 9, 2023
@seisman seisman added this to the 0.10.0 milestone Apr 9, 2023
@seisman seisman added the needs review This PR has higher priority and needs review. label Apr 9, 2023
@seisman seisman requested a review from a team April 11, 2023 06:27
@michaelgrund michaelgrund added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Apr 11, 2023
Copy link
Member

@yvonnefroehlich yvonnefroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (but I did not check explicitly whether all occurrences are updated).

@seisman seisman merged commit 8cacfc4 into main Apr 11, 2023
@seisman seisman deleted the pip-as-module branch April 11, 2023 23:17
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "pip install" with "python -m pip install"
3 participants