-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate provision-with-micromamba to setup-micromamba #2536
Conversation
The mamba-org/provision-with-micromamba GitHub Action is about to be deprecated in favour of https://github.com/mamba-org/setup-micromamba, see mamba-org/provision-with-micromamba#122. Also replaced the extra-specs paramete with create-args instead.
In ci_tests.yaml, you need to switch from include:
- python-version: '3.9'
numpy-version: '1.21'
optional-packages: ''
- python-version: '3.11'
numpy-version: '1.24'
optional-packages: |
contextily
geopandas
ipython
rioxarray
sphinx-gallery
[...]
packaging
${{ matrix.optional-packages }}
build to include:
- python-version: '3.9'
numpy-version: '1.21'
optional-packages: ''
- python-version: '3.11'
numpy-version: '1.24'
optional-packages: >-
contextily
geopandas
ipython
rioxarray
sphinx-gallery
[...]
packaging${{ matrix.optional-packages }}
build (beware the extra space at |
Forgot that we don't use the environment.yml file
This reverts commit 31b775f.
Need to format the blank spaces a bit more carefully.
Thanks for the tip @pavelzw! I was wondering why the error for the CI test with optional dependencies was different to the one without. The single space before |
This reverts commit a6b19f7.
Co-Authored-By: Dongdong Tian <seisman.info@gmail.com>
In PR #2435, I removed the I don't find the package list in the new action output. I think we should add |
Good catch. done in 9808f18 and ea3afa9 (need to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Hmm, the readthedocs build is failing with an unrelated |
I wanted to add this in |
If you update to |
Description of proposed changes
The mamba-org/provision-with-micromamba GitHub Action is about to be deprecated in favour of https://github.com/mamba-org/setup-micromamba, see mamba-org/provision-with-micromamba#122. Also replaced the extra-specs parameter with create-args instead.
Migration reference: mamba-org/provision-with-micromamba#114
Supersedes #2435
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version