Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure.meca: the 'scale' parameter can accept int/float/str values #2566

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

seisman
Copy link
Member

@seisman seisman commented Jun 6, 2023

Description of proposed changes

Currently, the scale parameter doesn't accept int or float values like scale=1.0, because we use kwargs["S"] = data_format + scale to build the -S argument. int/float scales are valid and should be supported.

This PR fixes the issue. The test_meca_spec_dict_all_scalars is updated to catch the bug.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added bug Something isn't working needs review This PR has higher priority and needs review. labels Jun 6, 2023
@seisman seisman added this to the 0.10.0 milestone Jun 6, 2023
@michaelgrund michaelgrund added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Jun 6, 2023
@seisman seisman merged commit 39c8eeb into main Jun 7, 2023
@seisman seisman deleted the meca-nonstr-scale branch June 7, 2023 04:03
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants