Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove the setup-node workaround from the dvc-diff workflow #2776

Merged
merged 4 commits into from
Oct 29, 2023

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 29, 2023

Description of proposed changes

The workaround added in #2549 is no longer necessary.

After removing the setup-node step, the dvc-diff workflow runs successfully (see #2776 (comment)).

Closes #2769.

@seisman seisman closed this Oct 29, 2023
@seisman seisman reopened this Oct 29, 2023
@github-actions
Copy link
Contributor

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_basemap.png

Image diff(s)

Added images

Modified images

Path Old New
test_basemap.png

Report last updated at commit 0afd0d9

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Oct 29, 2023
@seisman seisman added this to the 0.11.0 milestone Oct 29, 2023
@seisman seisman marked this pull request as ready for review October 29, 2023 14:49
@seisman seisman requested a review from weiji14 October 29, 2023 14:49
@@ -76,7 +70,7 @@ jobs:
cp pygmt/tests/baseline/*.png pygmt/tests/baseline-new/
# Pull images in the main branch from cloud storage
git checkout main
dvc pull --remote upstream
dvc pull --remote upstream --force
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/GenericMappingTools/pygmt/actions/runs/6684026542/job/18160840366?pr=2776.

branch 'main' set up to track 'origin/main'.
ERROR: failed to pull data from the cloud - Can't remove the following unsaved files without confirmation. Use `--force` to force.
/home/runner/work/pygmt/pygmt/pygmt/tests/baseline/test_basemap.png

@seisman seisman merged commit 468f4e8 into main Oct 29, 2023
13 of 19 checks passed
@seisman seisman deleted the ci/dvc-dif branch October 29, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants