Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install instructions #279

Merged
merged 4 commits into from
Jan 25, 2019
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Jan 24, 2019

Description of proposed changes

  1. Point Windows users to use the GMT6 binaries provided by Joaquim.
  2. Instructions to create conda environment and install dependencies
  3. Fix the description of GMT_LIBRARY_PATH, since GMT is no longer installed via conda

Fixes #213.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@seisman seisman requested a review from leouieda January 24, 2019 19:54
Copy link
Member

@leouieda leouieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seisman 👍 Just a few minor changes.

doc/install.rst Outdated Show resolved Hide resolved
doc/install.rst Outdated Show resolved Hide resolved
leouieda and others added 3 commits January 24, 2019 16:21
Co-Authored-By: seisman <seisman.info@gmail.com>
Co-Authored-By: seisman <seisman.info@gmail.com>
@seisman
Copy link
Member Author

seisman commented Jan 24, 2019

@leouieda I've accepted your changes and merged master branch.

@leouieda
Copy link
Member

Thanks @seisman! We should actually try setting up AppVeyor with those binaries. It will probably fail and we might have problems testing different GMT versions on Windows and Linux.

@leouieda leouieda merged commit b5b6fc6 into master Jan 25, 2019
@leouieda leouieda deleted the install-guide-for-windows-users branch January 25, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GMT6 binaries for Windows
2 participants