Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure.timestamp: Add type hints to parameters #2890

Merged
merged 8 commits into from
Jan 2, 2024
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 17, 2023

@seisman seisman added maintenance Boring but important stuff for the core devs typing Type hints and static type checking labels Dec 17, 2023
@seisman seisman changed the title Figure.timestamp: Add type hints Figure.timestamp: Add type hints to parameters Dec 17, 2023
@seisman seisman added the needs review This PR has higher priority and needs review. label Dec 17, 2023
@seisman seisman added this to the 0.11.0 milestone Dec 17, 2023
@seisman seisman requested a review from a team December 22, 2023 14:23
@seisman seisman removed the needs review This PR has higher priority and needs review. label Jan 2, 2024
@seisman seisman enabled auto-merge (squash) January 2, 2024 13:49
@seisman seisman disabled auto-merge January 2, 2024 15:35
@seisman seisman added needs review This PR has higher priority and needs review. and removed needs review This PR has higher priority and needs review. labels Jan 2, 2024
@seisman seisman merged commit e0c306f into main Jan 2, 2024
18 of 19 checks passed
@seisman seisman deleted the typehints/timestamp branch January 2, 2024 16:06
@seisman
Copy link
Member Author

seisman commented Jan 2, 2024

I've self-approved this PR so that I can continue with other more interesting coding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs typing Type hints and static type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant