-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance by avoiding loading the GMT library repeatedly #2930
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
51f3943
clib: Search and load the GMT library only one time
seisman 713b0e9
[skip ci] Improve comments
seisman 6936f59
Merge branch 'main' into clib/load-libgmt
seisman f589ff8
Add a unittest
seisman 401a0f8
Apply suggestions from code review
seisman 48c00ae
Add a test to check multiprocessing support
seisman b31fe19
Mark the test as xfail on Windows
seisman ce263ec
Merge branch 'main' into clib/load-libgmt
seisman 820e11b
Improve tests
seisman 7a2d96d
Remove the multiprocessing test
seisman bf6083f
Merge branch 'main' into clib/load-libgmt
seisman 11cb76b
Merge branch 'main' into clib/load-libgmt
seisman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe better to put this unit test in
test_session_management.py
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer to keep it in
test_clib_loading.py
because this unit test is actually not related to session management.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I kinda wanted to move the test since
test_clib_loading.py
has 300+ lines of code, whiletest_session_management.py
has <100 lines, and we're kinda checking thatSession()
doesn't reload libgmt here, but up to you 🙂