Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Trigger the cache_data workflow in PRs if cache files are added/deleted/updated #2939

Merged
merged 3 commits into from
Jan 3, 2024
Merged

CI: Trigger the cache_data workflow in PRs if cache files are added/deleted/updated #2939

merged 3 commits into from
Jan 3, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Jan 2, 2024 •
edited
Loading

Description of proposed changes

Implement the idea proposed in #2937 (comment).

Changes in this PR:

  • Move the download_test_data function from pygmt/helpers/testing.py into a separate file pygmt/helpers/caching.py and rename it to cache_data.py
  • Update the cache_data workflow so that it's automatically triggered if pygmt/helpers/caching.py or .github/workflows/cache_data.yaml changes.

@seisman seisman added maintenance Boring but important stuff for the core devs needs review This PR has higher priority and needs review. labels Jan 2, 2024
@seisman seisman added this to the 0.11.0 milestone Jan 2, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 2, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2939 will improve performances by 23.38%

Comparing cache-data (24bb4fe) with main (da36673)

Summary

⚡ 1 improvements
✅ 63 untouched benchmarks

Benchmarks breakdown

Benchmark main cache-data Change
⚡ test_sph2grd_no_outgrid 4.7 s 3.8 s +23.38%

michaelgrund
michaelgrund approved these changes Jan 3, 2024
View reviewed changes
pygmt/helpers/caching.py Outdated Show resolved Hide resolved
@michaelgrund michaelgrund added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Jan 3, 2024
@seisman @michaelgrund @yvonnefroehlich
Apply suggestions from code review
24bb4fe 
Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@seisman seisman merged commit 69adbef into main Jan 3, 2024
14 of 16 checks passed
@seisman seisman deleted the cache-data branch January 3, 2024 10:34
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvonnefroehlich yvonnefroehlich yvonnefroehlich left review comments

@michaelgrund michaelgrund michaelgrund approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@seisman @michaelgrund @yvonnefroehlich