Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Suppress warnings by explicitly setting output_type to 'file' #3135

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 22, 2024

Suppress following warnings:

pygmt/tests/test_blockm.py::test_blockmean_input_filename
pygmt/tests/test_blockmedian.py::test_blockmedian_input_filename
  /home/runner/work/pygmt/pygmt/pygmt/src/blockm.py:49: RuntimeWarning: Changing 'output_type' from 'pandas' to 'file' since 'outfile' parameter is set. Please use output_type='file' to silence this warning.
    output_type = validate_output_table_type(output_type, outfile=outfile)

pygmt/tests/test_grdtrack.py::test_grdtrack_input_csvfile_and_dataarray
  /home/runner/work/pygmt/pygmt/pygmt/src/grdtrack.py:301: RuntimeWarning: Changing 'output_type' from 'pandas' to 'file' since 'outfile' parameter is set. Please use output_type='file' to silence this warning.
    output_type = validate_output_table_type(output_type, outfile=outfile)

pygmt/tests/test_project.py::test_project_output_filename
  /home/runner/work/pygmt/pygmt/pygmt/src/project.py:235: RuntimeWarning: Changing 'output_type' from 'pandas' to 'file' since 'outfile' parameter is set. Please use output_type='file' to silence this warning.
    output_type = validate_output_table_type(output_type, outfile=outfile)

pygmt/tests/test_select.py::test_select_input_filename
  /home/runner/work/pygmt/pygmt/pygmt/src/select.py:208: RuntimeWarning: Changing 'output_type' from 'pandas' to 'file' since 'outfile' parameter is set. Please use output_type='file' to silence this warning.
    output_type = validate_output_table_type(output_type, outfile=outfile)

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog final review call This PR requires final review and approval from a second reviewer labels Mar 22, 2024
@seisman seisman added this to the 0.12.0 milestone Mar 22, 2024
@seisman seisman merged commit 1eb6dec into main Mar 23, 2024
15 of 16 checks passed
@seisman seisman deleted the tests/silent-warnings branch March 23, 2024 18:05
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants