GMT-Ghostscript incompatibility: Give recommendations and extend examples #3249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvonnefroehlich
added
documentation
yvonnefroehlich
changed the title
seisman
reviewed
May 14, 2024
seisman
reviewed
May 14, 2024
| fig.coast(region="g", frame=True, shorelines=1) | ||
| fig.coast(projection="N10c", region="g", frame=True, land="tan", water="lightblue") | ||
| # Add a semi-transparent text element | ||
| fig.text(position="MC", text="PyGMT", font="60p,Helvetica-Bold,red@75") | ||
| fig.show() | ||
| ``` |
There was a problem hiding this comment.
It would be great if we can add the image here so that it's more straightforward to see the differences if any. But I'm unsure what's the best way to add the image here.
There was a problem hiding this comment.
Yes, this would definitely be nice! I was also thinking about this while writing the explanation comment. I have to see when I have time to figure out a solution - maybe a table: left the code and right the image?
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
May 15, 2024
Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
May 16, 2024
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
May 16, 2024
seisman
reviewed
May 16, 2024
|
Please also make the PR title shorter. |
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
yvonnefroehlich
changed the title
yvonnefroehlich
changed the title
yvonnefroehlich
changed the title
seisman
reviewed
May 17, 2024
|
Looks good to me already. Do you still have more changes to add? |
seisman
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The incompatibility of some GMT Ghostscript version combinations causes not working transparency.
This PR adds
Preview: https://github.com/GenericMappingTools/pygmt/tree/mention-gs-gmt-transprency?tab=readme-ov-file#getting-started
Preview: https://pygmt-dev--3249.org.readthedocs.build/en/3249/install.html#testing-your-install
Preview: https://pygmt-dev--3249.org.readthedocs.build/en/3249/install.html#common-installation-issues
Preview: https://github.com/GenericMappingTools/pygmt/blob/mention-gs-gmt-transprency/.github/ISSUE_TEMPLATE/4-release_checklist.md
Related to
Fixes: #3242 (comment)
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code