Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPEC 0: Set minimum required version to NumPy 1.24+ #3286

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Jun 17, 2024

Description of proposed changes

Following SPEC0 policy where NumPy 1.23 is to be dropped on or after 21 June 2024 (in a minor version increment, i.e. for PyGMT v0.13.0). Bumps minimum supported NumPy version to 1.24 in the pyproject.toml, requirements.txt and environment.yml files. Also update doc/minversions.md to mention NumPy 1.24+ requirement.

This is in line with PyGMT's policy on SPEC0 at https://www.pygmt.org/v0.12.0/maintenance.html#dependencies-policy, xref #2863.

Supersedes #2991.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

Following SPEC 0 policy. Bumps minimum supported
NumPy version to 1.24 in the pyproject.toml, requirements.txt
and environment.yml files. Also update doc/minversions.md
to mention NumPy 1.24+ requirement.
@weiji14 weiji14 added the deprecation Deprecating a feature label Jun 17, 2024
@weiji14 weiji14 added this to the 0.13.0 milestone Jun 17, 2024
@weiji14 weiji14 self-assigned this Jun 17, 2024
@weiji14 weiji14 marked this pull request as ready for review June 17, 2024 02:23
@seisman seisman merged commit 7b09d88 into main Jun 17, 2024
18 of 20 checks passed
@seisman seisman deleted the spec0/numpy-1.24 branch June 17, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecating a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants