Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_tile_map: Register the rio accessor by importing rioxarray so the returned raster has CRS #3323

Merged
merged 8 commits into from
Jul 10, 2024
Merged

load_tile_map: Register the rio accessor by importing rioxarray so the returned raster has CRS #3323

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
acf48c3
load_tile_map: Register the rio accessor by importing rioxarray so th…
seisman Jul 10, 2024
0b9fae2
Get rid of _HAS_RIOXARRAY
seisman Jul 10, 2024
be840ac
Update pygmt/datasets/tile_map.py
seisman Jul 10, 2024
13e3283
Merge branch 'main' into tilemap/rioxarray
seisman Jul 10, 2024
9ecc39d
Fix a typo
seisman Jul 10, 2024
42922b8
Ignore the ruff SIM105 error
seisman Jul 10, 2024
5b165a9
Update pygmt/datasets/tile_map.py
seisman Jul 10, 2024
ce514a4
Add import
seisman Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pygmt/datasets/tile_map.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
:class:`xarray.DataArray`.
"""

import contextlib
from typing import Literal

from packaging.version import Version
Expand All @@ -16,6 +17,10 @@
TileProvider = None
_HAS_CONTEXTILY = False

with contextlib.suppress(ImportError):
# rioxarray is needed to register the rio accessor
import rioxarray # noqa: F401

import numpy as np
import xarray as xr

Expand Down Expand Up @@ -117,6 +122,10 @@ def load_tile_map(
* y (y) float64 ... -7.081e-10 -7.858e+04 ... -1.996e+07 -2.004e+07
* x (x) float64 ... -2.004e+07 -1.996e+07 ... 1.996e+07 2.004e+07
spatial_ref int64 ... 0
>>> # CRS is set only if rioxarray is available
>>> if hasattr(raster, "rio"):
... raster.rio.crs
Comment on lines 124 to +127
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, we probably don't need the if hasattr(raster, "rio") check, because the spatial_ref int64 ... 0 line above (added in #3321) already means that rioxarray is used (the doctests CI run with rioxarray installed). But I guess it'll be good to mention rioxarray somewhere in the docstring, albeit indirectly.

CRS.from_epsg(3857)
"""
if not _HAS_CONTEXTILY:
raise ImportError(
Expand Down