PYGMT_USE_EXTERNAL_DISPLAY should NOT disable image display in Jupyter notebook environment #3418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
seisman
changed the title
seisman
added
bug
|
I'm self-proving this PR so that we can continue other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
See #3416 for the bug report.
The environment variable
PYGMT_USE_EXTERNAL_DISPLAYshould only disable images previews when the display method is"external". Otherwise, images won't be shown in notebook environment.Changes in this PR was cherry-picked from PR #3396.
I've built the documentation locally, and can confirm that the issue #3416 can be fixed by this PR.
Closes #3416.