-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPEC 0: Set minimum supported versions to pandas>=2.0 and xarray>=2023.04 #3460
Conversation
Yeah, I think we'll need to bump the minimum required
I would consider that xarray 2023.03 supporting pandas 2.0 is a critical bug fix 🙂, so would prefer to get this into PyGMT v0.14.0. |
I'm OK with making it to v0.14.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update doc/minversions.rst
too.
Can we also agree on a consistent title for SPEC 0 updates? We've been inconsistent in https://www.pygmt.org/v0.13.0/changes.html:
- SPEC 0: Bump minimum supported version to xarray 2022.09
- SPEC 0: Set minimum supported versions to Python>=3.10, pandas>=1.5 and xarray>=2022.06
- NEP29: Set minimum required version to NumPy 1.23+
I like the middle one using pandas>=1.5
, but no strong opinions.
No need to update this file after #3380.
Sounds good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update
doc/minversions.rst
too.No need to update this file after #3380.
Oh yes, old habits die hard. LGTM!
Description of proposed changes
Following SPEC0, we should drop pandas 1.5 and xarray 2022.09 support in 2024 Q3, but now we have dependency conflicts.
Following pydata/xarray#7716 (comment), xarray 2023.04 works with pandas 2.0. Then we must decide whether to merge this PR now (violating the SPEC0 policy) or wait until April 2025.
I prefer to wait until April 2025, so adding this PR to milestone v0.16.0.
Previous pandas version bump at #3043.