Move Figure.psconvert into a separate file #3553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
seisman
commented
Oct 24, 2024
| @@ -374,6 +244,9 @@ def savefig( # noqa: PLR0912 | |||
| raise GMTInvalidInput(msg) | |||
| kwargs["W"] = True | |||
|
|
|||
| # pytest-mpl v0.17.0 added the "metadata" parameter to Figure.savefig, which | |||
There was a problem hiding this comment.
These lines were initially added to Figure.psconvert in #3054, but I feel it makes more sense to add the lines in Figure.savefig instead.
michaelgrund
approved these changes
Oct 25, 2024
michaelgrund
added
final review call
Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
seisman
removed
the
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source code for
Figure.psconverthas existed in thepygmt/figure.pyfile since #31. I think it makes more sense to move it into a separate filepygmt/src/psconvert.py.