Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Continuous Benchmarking in Maintainers Guides #3631

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Nov 19, 2024

Description of proposed changes

We have been using the CodSpeed service for about 1 year since #2908. The service seems stable and can help us track the performance.

This PR documents "Continuous Benchmarking" in the "Maintainers Guides", then we should be able to close #2910.

Preview: https://pygmt-dev--3631.org.readthedocs.build/en/3631/maintenance.html

@seisman seisman added documentation Improvements or additions to documentation needs review This PR has higher priority and needs review. labels Nov 19, 2024
@seisman seisman added this to the 0.14.0 milestone Nov 19, 2024
@seisman seisman requested a review from weiji14 November 19, 2024 06:49
@seisman seisman changed the title Document Continuous Benchmarking used in PyGMT Document Continuous Benchmarking in Maintainers Guides Nov 19, 2024
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seisman. Do we also want to mention how the https://github.com/apps/codspeed-hq bot works? Or how a run/benchmark label needs to be put on a PR to get the benchmarks to run?

doc/maintenance.md Outdated Show resolved Hide resolved
@seisman
Copy link
Member Author

seisman commented Nov 19, 2024

Do we also want to mention how the https://github.com/apps/codspeed-hq bot works?

This is a one-off thing, and it's well documented at https://docs.codspeed.io/, so I guess we don't have to document it.

Or how a run/benchmark label needs to be put on a PR to get the benchmarks to run?

Added in f508d4e.

@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Nov 19, 2024
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Nov 19, 2024
@seisman seisman merged commit 20dc597 into main Nov 19, 2024
10 of 11 checks passed
@seisman seisman deleted the doc/benchmark branch November 19, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmark performance of PyGMT functions
3 participants