Remote Datasets: Use complete word for units in "load_remote_dataset" and related tests #3725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvonnefroehlich
added
maintenance
yvonnefroehlich
changed the title
Merged
7 tasks
seisman
reviewed
Dec 26, 2024
| @@ -57,7 +57,7 @@ class GMTRemoteDataset(NamedTuple): | |||
| datasets = { | |||
| "earth_age": GMTRemoteDataset( | |||
| description="EarthByte Earth seafloor crustal age", | |||
| units="Myr", | |||
| units="million years", | |||
There was a problem hiding this comment.
I don't think "million years" are valid units.
Let's focus on "meters" vs "m" in this PR.
There was a problem hiding this comment.
Yes! I was unsure with the crustal age dataset. Also have a preference to keep Myr.
See commit 676ece8 for the update.
seisman
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
See comment #3706 (comment) and the following comments for context.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code