Migrate the 'no_clip' parameter to the new alias system #4103
+57
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
pygmt/src/contour.py
Outdated
Comment on lines
113
to
115
| no_clip | ||
| Do **not** clip contours or image at the frame boundaries [Default is ``False`` | ||
| to fit inside ``region``]. |
There was a problem hiding this comment.
I am wondering to what "image" is refering here.
There was a problem hiding this comment.
It comes from the upstream documentation at https://docs.generic-mapping-tools.org/6.5/contour.html#n.
Here "image" is used because contour can color the triangles using a CPT. See the example below:
gmt begin map
gmt makecpt -Cseis -T600/1000/100
gmt basemap -R0.5/6/0.5/6 -JX10c/10c -Baf
gmt plot @Table_5_11.txt -Sc0.2c
gmt contour @Table_5_11.txt -Wthin -C -I -N -t50
gmt end show
There was a problem hiding this comment.
Ah, thanks for the example 🙂!
Not really happy with this formulation, but do not have a good alternative.
yvonnefroehlich
approved these changes
Sep 25, 2025
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some wrappers have the
no_clipparameter, which can be either False or True. This PR migrates the parameter to the new alias system.no_clipinFigure.plotandFigure.plot3dare not updated in this PR, because in these two methods,no_clipcan be False, True,"c"or"r"and we need to discuss the long-form arguments for "c"/"r". So leave it to a separate PR instead.