-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Figure.show for displaying previews in Jupyter notebooks and external viewers #529
Merged
Merged
Changes from all commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
7ca1721
Improve show() function for displaying previews in notebooks or using…
seisman 75b0b38
Fix
seisman c7cc49a
Merge branch 'master' into new-display
seisman 6f8f182
Merge branch 'master' into new-display
seisman 97ba370
Merge branch 'master' into new-display
seisman 4e0e776
Merge branch 'master' into new-display
seisman ee77d9a
Merge branch 'master' into new-display
seisman a09eb43
Merge branch 'master' into new-display
seisman 6bb3d49
Merge branch 'master' into new-display
seisman d9a1f94
Merge branch 'master' into new-display
seisman 2d8d38b
Merge branch 'master' into new-display
seisman fe69d5b
Merge branch 'master' into new-display
seisman d6b48a8
Merge branch 'master' into new-display
weiji14 fcef995
Lint code
weiji14 c19fe6f
Merge branch 'master' into new-display
seisman 50f79d1
Formatting the codes
seisman b96130a
Merge branch 'master' into new-display
seisman 7ba31e1
Merge branch 'master' into new-display
seisman 4177a46
Change PYGMT_DISABLE_EXTERNAL_DISPLAY to PYGMT_USE_EXTERNAL_DISPLAY
seisman 4b066a5
Merge branch 'master' into new-display
seisman 4ca9367
Fix errors in previous merge
seisman e6d1ef9
Fix comments
seisman 753dbf9
Updates
seisman 4c1c981
Merge branch 'master' into new-display
seisman 5c9bed7
fix
seisman cb37eed
Fix
seisman d886418
Merge branch 'master' into new-display
seisman 87abc86
Merge branch 'master' into new-display
seisman 6b9fb8c
Merge branch 'master' into new-display
seisman bf6f2b1
Merge branch 'master' into new-display
seisman da8a6d7
Merge branch 'master' into new-display
seisman fccde41
Set PYGMT_USE_EXTERNAL_DISPLAY in html target
seisman e34b888
Improve docs [skip ci]
seisman 77adbaf
Merge branch 'master' into new-display
seisman 011c7a9
Merge branch 'master' into new-display
seisman e1c67a5
Update docstrings
seisman 6f638f3
Fix the return value of Figure.show() in inset.py
seisman ca0ecb3
Improve dpi and width
seisman cdae975
Merge branch 'master' into new-display
seisman be677e4
Merge branch 'master' into new-display
seisman 777d6bd
Formatting
seisman b04f5b9
Set IPython to None if not available
seisman c2b6319
Check the case that notebook is selected but IPython is not available
seisman 4e765c2
Fix a lint issue
seisman 7da2358
Merge branch 'master' into new-display
seisman 5861c6b
Remove the changes for dpi and width settings
seisman 794cae6
Merge branch 'master' into new-display
seisman 6e59fa3
Use a single parmeter SHOW_CONFIG['method'] for display method
seisman 0c62718
Figure.show() now returns the Image object
seisman 63db193
Improve docstrings
seisman 3bd180a
Document the return of Figure.show()
seisman d748ae0
Improve function docstrings
seisman e6b3f65
IPython.display.display is no longer used
seisman 05b3962
Merge branch 'master' into new-display
seisman 92c7258
Merge branch 'master' into new-display
seisman 7d53b1a
Figure.show() now returns nothing
seisman 14af2ca
Merge branch 'master' into new-display
seisman db038b0
Update docstrings using bold text
seisman 1b50edb
Merge branch 'master' into new-display
seisman 9b44165
Fix a comment [skip ci]
seisman 81fb312
Improve Fig.show() comment
seisman 9c17112
Merge branch 'master' into new-display
seisman 6fa020d
Add a test for invalid arguments of set_display()
seisman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking whether to put
set_display
alongsideconfig
and have a heading like "Advanced configuration" or something like that.