Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically cancel in-progress CI runs of old commits #544

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

seisman
Copy link
Member

@seisman seisman commented Jul 23, 2020

Description of proposed changes

Add the Cancel Workflow Action action as the first step for testing.

When a new commit is pushed, the previous runs in the same PR will be cancelled. So we don't have to wait for too long time for the previous outdated CI jobs.

Fixes #543

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@seisman seisman marked this pull request as ready for review July 23, 2020 00:19
@seisman seisman changed the title Add a step to cancel previous jobs Automatically cancel in-progress CI runs for new commits Jul 23, 2020
@seisman seisman changed the title Automatically cancel in-progress CI runs for new commits Automatically cancel in-progress CI runs of old commits Jul 23, 2020
@seisman seisman requested a review from weiji14 July 23, 2020 00:20
@weiji14 weiji14 added the maintenance Boring but important stuff for the core devs label Jul 23, 2020
@seisman seisman added this to the 0.2.x milestone Jul 23, 2020
@seisman
Copy link
Member Author

seisman commented Jul 23, 2020

Look at the two runs: old runs and new current runs. I think it works well.

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks @seisman, you're really becoming an expert on Github Actions 😆

@seisman
Copy link
Member Author

seisman commented Jul 23, 2020

Thanks for the good and easy-to-read documentation of most GitHub Actions!

@seisman seisman merged commit 3b83889 into master Jul 23, 2020
@seisman seisman deleted the cancel-previous-runs branch July 23, 2020 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically cancel previous workflow runs in the same PR
2 participants