Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test to check passing arrays of mixed dtypes to GMT #547

Merged
merged 4 commits into from
Jul 26, 2020
Merged

Add a test to check passing arrays of mixed dtypes to GMT #547

merged 4 commits into from
Jul 26, 2020

Conversation

seisman
Copy link
Member

@seisman seisman commented Jul 25, 2020 •
edited
Loading

Description of proposed changes

This PR contains two commits:

The bug was first reported in #255, but it turns out to be an upstream bug in GMT 6.0.0. The upstream bug was fixed in GMT 6.1.0. This PR adds a test to make sure that GMT won't break it again.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@seisman seisman requested a review from weiji14 July 25, 2020 04:13
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Jul 25, 2020
@seisman seisman added this to the 0.2.x milestone Jul 25, 2020
seisman and others added 2 commits July 25, 2020 19:50
@seisman
Merge branch 'master' into test-mixed-types
dcf021c
@seisman @weiji14
Use itertools.permutations instead
559807e 
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@seisman seisman merged commit 11235b0 into master Jul 26, 2020
@seisman seisman deleted the test-mixed-types branch July 26, 2020 00:24
This was referenced Sep 19, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

Figure.plot fails to plot lines correctly
2 participants
@seisman @weiji14