-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add common alias verbose (V) #550
Conversation
@@ -36,6 +36,18 @@ | |||
color : str | |||
Select color or pattern for filling of symbols or polygons. Default | |||
is no fill.""", | |||
"V": """\ | |||
verbose : str |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, the GMT experimental long options use verbosity
and spherical
for -V and -j (https://github.com/GenericMappingTools/gmt/blob/master/src/gmt_init.c#L383), while GMT.jl uses verbose
and spheric_dist | spherical_dist
(https://www.generic-mapping-tools.org/GMT.jl/latest/#GMT.grdmask).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would definitely prefer 'verbose' for V, it's similar to most command-line arguments.
As for 'j', I've merged the PR already, but could make a quick change. The GMT.jl documentation actually points to http://docs.generic-mapping-tools.org/latest/gmt.html#j-full (i.e. capital J) rather than the proper link at https://docs.generic-mapping-tools.org/latest/gmt.html#distcalc-full (notice the distcalc
in the link).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I also prefer verbose
for -V.
For j, I'm OK with the names. It depends on if we want to keep consistent with other GMT projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I believe the GMT server is up.
Description of proposed changes
Select verbosity level [Default is w], which modulates the messages written to stderr. See https://docs.generic-mapping-tools.org/6.1/gmt.html#v-full. Choose among 7 levels of verbosity:
Cherry-picked from #546.
Fixes #
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.