Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a failing test due to GMT API change #556

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Fix a failing test due to GMT API change #556

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3f35e4
Fix a failing test due to GMT API change
seisman Aug 6, 2020
40ce4ae
Merge branch 'master' into point-or-surface
seisman Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pygmt/tests/test_clib_put_matrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def test_put_matrix_grid():
with GMTTempFile() as tmp_file:
lib.write_data(
"GMT_IS_MATRIX",
"GMT_IS_SURFACE",
"GMT_IS_POINT",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem like we use lib.write_data on any user-facing code, or very much in the clib. I know GMT can write an ASCII grid, but maybe we should also test with "GMT_IS_SURFACE" to ensure that:

  1. lib.write_data can write to a NetCDF properly; and
  2. We can use xarray to read from that NetCDF file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds a good idea, but it needs 6.1.1, so better to add the test in a new pr and only merge that pr after we bump to gmt 6.1.1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok (forgot that we're still on GMT 6.1.0). Leave it until end of the month then.

"GMT_CONTAINER_AND_DATA",
wesn,
tmp_file.name,
Expand Down