-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let plot() accept record-by-record transparency #626
Conversation
df893a8
to
66d0c85
Compare
The feature is already implemented, and I add three new tests for it. |
9718008
to
d633361
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Could use a gallery example but that can be done in a separate PR.
fig_ref, fig_test = Figure(), Figure() | ||
# Use single-character arguments for the reference image | ||
with GMTTempFile() as tmpfile: | ||
np.savetxt(tmpfile.name, np.c_[x, y], fmt="%d") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This np.c_
is new to me, but ok.
Description of proposed changes
plot()
can accept a list of transparency so that each symbol can has its own transparency level.Address #615.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.