-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate PyPI release to GitHub Actions #679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a suggestion following @leouieda's PR at fatiando/pooch#196. However, I'm not sure if I like this workaround, since we will have to switch from versioneer to setuptools_scm (#671) sooner or later.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
See the "fake" release in the test pypi repository: https://test.pypi.org/project/pygmt/0.2.0.post0.dev52/#history |
I would actually recommend looking at the workflows here instead: https://github.com/fatiando/boule/tree/master/.github/workflows We're also trying out a tool called nox. It's pretty nice to automate some tasks with Python instead of clunky Makefiles that don't work on Windows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes will have to be documented under MAINTENANCE.md. Could you remove mention of Travis CI PyPI deployments at https://github.com/GenericMappingTools/pygmt/blob/v0.2.0/MAINTENANCE.md#travis-ci and place it under the Github Actions section at https://github.com/GenericMappingTools/pygmt/blob/v0.2.0/MAINTENANCE.md#github-actions instead please?
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting there! Just one minor suggestion to change 'archive' to 'wheel'.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description of proposed changes
This PR migrate the PyPI release job from Travis CI to GitHub Actions.
References:
Address #566
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Notes
/format
in the first line of a comment to lint the code automatically