-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutorial for contour maps #705
Add tutorial for contour maps #705
Conversation
Remove duplicate word Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Update order on tutorials Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Update default projection
Fix typo; "blow" to "below"
@seisman Pardon my unfamiliarity with the open source contributing process, but I just want to confirm that you are not waiting on any changes/additional contributions for this PR? Thanks! |
@willschlitzer Sorry for the absence. I'm a little busy yesterday and will leave more reviews/comments in the next few days. |
Removed region from the method description because it is not a required arguement Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@willschlitzer One more thing, although it's not mandatory, it would be better if you can wrap the lines to no longer than 88 characters, to make it more readable. |
Move grid variable assignment to top of script Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Adding comment for grid variable Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
typo correction Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@seisman Now that I've received feedback on how to document the example code, I decided to commit the example I had to include a colormap on the contour map. It seemed easier to commit it now to include it in this pull request, but please let me know if I overstepped and should have instead waited for a separate pull request. |
It looks good to add a color map. |
@willschlitzer I just leave more comments on your new example. I think the tutorial is pretty good now. The only issue is that the tutorial is using the "15s" earth relief data. As you may know or not, these earth relief data are stored in the GMT data server, and GMT (or PyGMT) will download the grid tiles for the first time the data is used. Usually, each tile is smaller than 10 Mb, so it's not a problem for users. However, the Linux and Windows agents of GitHub Actions (the machine/service we're using to run tests and build documentation) sometimes can't download data from the GMT data server (#434 (comment)), so we have to cache the data using a macOS agent and let Linux/Windows re-use the caches (#530). Currently, only the following earth relief data are cached: pygmt/.github/workflows/cache_data.yaml Lines 33 to 36 in 5c8b851
It would be good if you can modify your examples using a low-resolution grid ( |
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@seisman I updated the region setting to "05m". I'm pretty unfamiliar with using the GMT Earth relief data date, but I was unable to use "10m," as I received a NotImplementedError that said it isn't supported for that resolution. Thanks for all of your feedback (and patience with my mistakes)! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it looks pretty good to me.
I'll merge this PR tomorrow. @GenericMappingTools/python if you find anything that should be fixed, please leave your comments in the next 24 hours. |
@seisman Thanks for all of the feedback throughout this process. I look forward to using my lessons learned on future pull requests on this project. |
@willschlitzer As mentioned in #707 (comment), feel free to open a new pull request to add yourself to the |
Created a tutorial on the usage of the grdcontour method to demonstrate creating a plot with contour lines and adjusting the intervals, annotations, and limits. Per the feedback from @seisman, I'm resubmitting this under it's own branch from my fork and not including the .ipynb file.